-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(other): update issue templates #1379
Conversation
"is epic a thing here?" Let's look at current list at https://github.com/cypht-org/cypht/issues and see if some would qualify. Would these qualify?
|
"Is devops needed?" Maybe for tasks like this: #1175 |
Epic is normally a greater goal, which then is comprised of several features. An example would be: "Provide an native android App" or "Implement AI driven E-Mail writing". Of the list you provide
In general I use Epic and Release types for planning purposes - normally users don't create those issue, but Project leads, eg. to define the scope of an upcoming release. This utilizes issues to track progress and have strategic notes/goals available for everyone. I am unsure this project qualifies for this kind of approach.
I think the linked issue would qualify for this - I tend to use Devops for everything related to the sorroundings of the project, like deployments, backups or github related things (this PR would qualify for this type). I am not 100% sure this projects qualifies for this, since except the website there is no deployments actively maintained by the project itself. Please decide what you need and I will adjust the PR accordingly. If you need more info, I can try to help. Another approach could be to provide all types and see how people use them - but that's something the project maintainers then need to do. Another thing: The PR title validation contains a regex, which enforces PRs to start with a lower case character after its scope and type definitions(see here) - this tends to confuse people and is there for the sake of visual pleasure in a changelog.
|
This is a community project so everyone is welcome to collaborate at all levels, including strategic. |
@ulfgebhardt: This is highly appreciated. In the last year, we have seen a record number of contributors: https://openhub.net/p/cypht/contributors/summary Lots of new features So I feel 1.4.x is more stable than 2.x (and even more so master) Over the next few months, the focus will increasingly be on fixing bugs. So we really need testers. So your help is deeply appreciated. |
I like this concept, and since we have examples, I think we should keep. |
Recently, I added "technical debt" on another bug tracker: How would deal with a task of this type? For example: #1136 |
Indeed, labels should aligned. Can you please review current labels and recommend which ones should be added / removed / merged? Thanks! |
I am undecided. Let's see what others say. |
This I would qualify as Refactor, since it improves/changes existing code without changing behaviour.
The following labels are used by the templates,
Hence, when all templates are merged
Since you seem not to require tests to pass (selenium is failing, but my branch can be merged) this decision can also be postponed and checked if things work as you expect - then the workflow can be made a requirement
To increase stability you need more tests and you MUST make them reliable - flaky tests as I see them in this project are not helping - they undermine the developers trust in the tests. It is very important, that a developer knows he did something wrong if he fails a test - he must be able to rely on that. It will make it easier for developers & for maintainers to judge if code is working correctly. Furthermore beginners are able to get automatic feedback from the development environment about their work without bothering people about it. I might be able to assist with that if I find the time. Test milestones would be:
|
works for me |
I added to https://github.com/cypht-org/cypht/labels |
works for me |
Feel free to merge then unless you want more feedback. |
This is fantastic! With guidance, our several keen and young developers will learn and improve tests. |
Was going to merge but the selenium tests are failing so I just relaunched them. |
Still failing but merged anyways. |
Regarding the PR title validation, I think it's a great thing people should consider. However, without clear documentation on what constitutes a valid title, the entire process becomes counterproductive. Many PRs are now struggling to pass this validation, and those that do often rely on the author's guesswork. Most importantly, what scopes are being validated against? For instance, when using the scope @ulfgebhardt, could you please look into making this validation criteria more explicit? |
Pullrequest
Update issue templates
Motivation
Since I am invested in testing cypht lately, i figured the issue templates are now 6 years old and have evolved on my end a bit.
So here is an update.
What has changed?
You can explore how things would look like here: https://github.com/ulfgebhardt/issue-templates
Example of a well formed changelog generated by https://github.com/CookPete/auto-changelog
Issues
Todo